Skip to content

build: add monitoring tag for lnd #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2025
Merged

build: add monitoring tag for lnd #1167

merged 1 commit into from
Nov 19, 2025

Conversation

@ZZiigguurraatt
Copy link
Contributor

@ZZiigguurraatt ZZiigguurraatt commented Nov 7, 2025

  • LND is now built with the monitoring tag enabled, which has been the default
    in standalone LND release builds since
    lightningnetwork/lnd@8491d0d

@gemini-code-assist
Copy link

gemini-code-assist bot commented Nov 7, 2025

Summary of Changes

Hello @ZZiigguurraatt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the LND build configuration by enabling the monitoring tag, ensuring consistency with upstream LND release builds. This change is reflected in the build flags and documented in the release notes.

Highlights

  • Build Configuration: The LND build process has been updated to include the monitoring tag, which aligns its compilation with the default settings used in standalone LND release builds.
  • Documentation: The release notes for version 0.16.0 have been updated to reflect the change of LND being built with the monitoring tag enabled.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 7, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the monitoring build tag for LND, aligning the build process with the defaults used in standalone LND releases. The change is straightforward and also includes a corresponding update to the release notes. I've found one minor formatting issue in the release notes that should be addressed.

@ZZiigguurraatt ZZiigguurraatt mentioned this pull request Nov 13, 2025
Open
@lightninglabs-deploy
Copy link

lightninglabs-deploy commented Nov 14, 2025

@ZZiigguurraatt, remember to re-request review from reviewers when ready

@ViktorT-11 ViktorT-11 self-requested a review November 18, 2025 17:15
ViktorT-11
ViktorT-11 approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏. As this doesn't change any behaviour unless prometheus.enable=true is set, I see no downside with adding these build flags.

ViktorT-11
ViktorT-11 approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@ViktorT-11 ViktorT-11 merged commit 1ed6662 into lightninglabs:master Nov 19, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ViktorT-11 ViktorT-11 ViktorT-11 approved these changes

@ellemouton ellemouton ellemouton approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZZiigguurraatt @lightninglabs-deploy @ViktorT-11 @ellemouton